History:Updating To MoinMoin 1.5: Difference between revisions

From MusicBrainz Wiki
Jump to navigationJump to search
(Answer for Dave (Imported from MoinMoin))
 
(@drunken-murdos ;) and other stuff (Imported from MoinMoin))
Line 16: Line 16:
*** The suggested hack doesn't necessarily "look" ugly if the containing external table is styleless-ed, though I agree this is a ugly hack :-) . Note that it won't be the first time we use table-style hack to have things rendering as we want them... -- [[User:dmppanda|dmppanda]] 20:18, 02 May 2007 (UTC)
*** The suggested hack doesn't necessarily "look" ugly if the containing external table is styleless-ed, though I agree this is a ugly hack :-) . Note that it won't be the first time we use table-style hack to have things rendering as we want them... -- [[User:dmppanda|dmppanda]] 20:18, 02 May 2007 (UTC)
**** see [http://newwiki.musicbrainz.org/murdos http://newwiki.musicbrainz.org/murdos]: the external table has the minimum style (''float:right;''), but it still ugly because of the style used for the TOC itself. I'm all for a general style for all pages, so that we would just have to call anywhere the TOC macro without hack ... -- [[User:murdos|murdos]]
**** see [http://newwiki.musicbrainz.org/murdos http://newwiki.musicbrainz.org/murdos]: the external table has the minimum style (''float:right;''), but it still ugly because of the style used for the TOC itself. I'm all for a general style for all pages, so that we would just have to call anywhere the TOC macro without hack ... -- [[User:murdos|murdos]]
***** Ok, now I'm completely confused. From the source, the TOC *is not* in a table... Furthermore, I don't get your point: the TOC div looks like <div class="table-of-contents">, hence TOCs already have a "general style for all pages" (defined in the sheet) -- [[User:dmppanda|dmppanda]] 23:13, 17 May 2007 (UTC)


==TODO==
==TODO==
Line 23: Line 24:
* update / clean [[Inter Wiki|InterWiki]] table
* update / clean [[Inter Wiki|InterWiki]] table
* check eventual regressions in transclusion of wikidocs
* check eventual regressions in transclusion of wikidocs
* fix the [[Wiki Spam Protection|WikiSpamProtection]] system

==DONE==

* check the address obfuscation system [[Image:Checkmark.png]] working
* check cards behavior:
* check cards behavior:
** old cards are working as far as I can tell
** old cards are working as far as I can tell
** I can't use the new syntax though. From [[MoinMoin:macro/CardMacro|macro/CardMacro]] I should be able to use parameters eg <code><nowiki>[[Card(Cards/WikiNavCard,test1)]]</nowiki></code>. See: [http://newwiki.musicbrainz.org/Cards/ArtistHeader http://newwiki.musicbrainz.org/Cards/ArtistHeader] for a non-working example. Am I missing something? -- [[User:dmppanda|dmppanda]] 20:31, 02 May 2007 (UTC)
** I can't use the new syntax though. From [[MoinMoin:macro/CardMacro|macro/CardMacro]] I should be able to use parameters eg <code><nowiki>[[Card(Cards/WikiNavCard,test1)]]</nowiki></code>. See: [http://newwiki.musicbrainz.org/Cards/ArtistHeader http://newwiki.musicbrainz.org/Cards/ArtistHeader] for a non-working example. Am I missing something? -- [[User:dmppanda|dmppanda]] 20:31, 02 May 2007 (UTC)
** There seem to be multiple, incompatible "Card" macro plugins around, with misleading docs. Check out the page now... - [[User:DaveEvans|DaveEvans]]
** There seem to be multiple, incompatible "Card" macro plugins around, with misleading docs. Check out the page now... - [[User:DaveEvans|DaveEvans]]
** WFM! -- [[User:dmppanda|dmppanda]] 23:13, 17 May 2007 (UTC)

* fix the [[Wiki Spam Protection|WikiSpamProtection]] system
* check the address obfuscation system [[Image:Checkmark.png]] working


==Interesting patches which may be applied==
==Interesting patches which may be applied==

Revision as of 23:13, 17 May 2007

Updating to MoinMoin 1.5

Purpose

The MusicBrainzWiki is about to be updated to the current stable version of MoinMoin (1.5.x).
This page should track all issues that will be encountered in the migration, and discussion on the best way to fix them.

A testing instance of MoinMoin 1.5 is available at http://newwiki.musicbrainz.org.

The related ticket is 2320.

Issues

  • TOCs are now embedded in a table: you can't have any more a floating TOC on the right of the page (in fact you can but you must embed the TOC table in another table, but this looks ugly).
    • Example: WikiWardening / http://newwiki.musicbrainz.org/WikiWardening
    • Possible solution: use MoinMoinPatch/AlterTableOfContentsAppearanceWithStyleSheet (it should be in the official release now) to set a global style to TOCs
      • The suggested hack doesn't necessarily "look" ugly if the containing external table is styleless-ed, though I agree this is a ugly hack :-) . Note that it won't be the first time we use table-style hack to have things rendering as we want them... -- dmppanda 20:18, 02 May 2007 (UTC)
        • see http://newwiki.musicbrainz.org/murdos: the external table has the minimum style (float:right;), but it still ugly because of the style used for the TOC itself. I'm all for a general style for all pages, so that we would just have to call anywhere the TOC macro without hack ... -- murdos
          • Ok, now I'm completely confused. From the source, the TOC *is not* in a table... Furthermore, I don't get your point: the TOC div looks like
            , hence TOCs already have a "general style for all pages" (defined in the sheet) -- dmppanda 23:13, 17 May 2007 (UTC)

TODO

  • change icons for interwiki and external links
  • update the MusicBrainz skin
  • update / clean InterWiki table
  • check eventual regressions in transclusion of wikidocs
  • fix the WikiSpamProtection system

DONE

  • check the address obfuscation system Checkmark.png working
  • check cards behavior:
    • old cards are working as far as I can tell
    • I can't use the new syntax though. From macro/CardMacro I should be able to use parameters eg [[Card(Cards/WikiNavCard,test1)]]. See: http://newwiki.musicbrainz.org/Cards/ArtistHeader for a non-working example. Am I missing something? -- dmppanda 20:31, 02 May 2007 (UTC)
    • There seem to be multiple, incompatible "Card" macro plugins around, with misleading docs. Check out the page now... - DaveEvans
    • WFM! -- dmppanda 23:13, 17 May 2007 (UTC)

Interesting patches which may be applied

FeatureRequests/TableOfContentsMinDepth: allow to specify a min depth with the TableOfContents macro.

With version 1.5, the page name is no longer automatically placed at the top as a title. So we'll have to use first-level headings to manually add a title. Problem is, that gets included in the TOC, which is not helpful.

  • Or, change the theme(s) to re-include the page title in the familiar place. - DaveEvans
    • As with this hack the title won't appear anyway on the transcluded doc, I would really prefer the suggested patch to be applied (which gives much more flexibility to TOCs), of course if this is not too much an hassle. -- dmppanda 20:18, 02 May 2007 (UTC)
    • Check out the "modern2" theme, compared to the (default) "modern" one.
    • We need H1 for wikidocselt pages, so I would actually consider it a benefit, if the theme would not show the title, but only the page did --DonRedman
    • I don't know what "wikidocselt" is, but if you mean what I know as "wikidocs", Moin 1.5.7 is compatible with 1.3.5 in this respect - neither version includes the page name as part of the extracted content. - DaveEvans
    • Yes, wikidocselted WikiPages are WikiDocs. I think our point here is: we need H1s in WikiDocs - so, we need to add them in WikiPages anyway, whatever if the wiki theme adds an extra page title or not. Hence, it makes TOCs a bit ugly, and this patch could really be useful. Now, as I said, if adding this patch is too much of an hassle... we can live with that... -- dmppanda 11:48, 07 May 2007 (UTC)
    • I have to say I don't really understand. Maybe we'll catch up on IRC sometime. Mostly what I don't understand is: Why do you say "we need H1s"? What do you mean by that - that the H1 needs to be part of the page content, or that the H1 needs to precede the page? Neither 1.5.7 nor 1.3.5 include H1s as part of the page content. - DaveEvans
    • Ok... I'll try to make it clear: we need (and want) to have titles in the wiki page content, specified by hand, using the h1 wiki equivalent syntax = Title = - no matter if the wiki prepends (outside of the page content) an additional page title or not (actually, would be better without IMO). The reason for that is that once transcluded, we want pages to have a title (which is not prepended anymore by the wiki theme of course). Having to do so, we end-up with TOCs that don't really look good - unless we have that mindepth patch. In the hope this is a bit more clear... as for IRC, sure! I'll try to hang out there next week. -- dmppanda 18:11, 17 May 2007 (UTC)